Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: refactor the statistics package use the RestrictedSQLExecutor API (#22636) (#22961) #23225

Merged
merged 4 commits into from
Mar 16, 2021
Merged

statistics: refactor the statistics package use the RestrictedSQLExecutor API (#22636) (#22961) #23225

merged 4 commits into from
Mar 16, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 10, 2021 •
edited
Loading

cherry-pick #22961 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23225

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/23225:release-4.0-8304d661f3ba

cherry-pick #22636 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/22961

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/22961:release-5.0-rc-17a65ab98bf1

What problem does this PR solve?

Issue Number:
For https://github.com/pingcap/tidb-test/issues/1152

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Code refactor using the secure API.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Release note

  • No release note

@ti-srebot
cherry pick pingcap#22961 to release-4.0
159ff68 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Mar 10, 2021
Merged
@ti-srebot ti-srebot added component/expression sig/sql-infra SIG: SQL Infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/4.0-cherry-pick type/5.0-rc-cherry-pick labels Mar 10, 2021
@ti-srebot ti-srebot added this to the v4.0.11 milestone Mar 10, 2021
@ti-srebot ti-srebot self-assigned this Mar 10, 2021
@ti-srebot
Copy link
Contributor Author

@ti-srebot you're already a collaborator in bot's repo.

@morgo morgo assigned tiancaiamao and unassigned ti-srebot Mar 10, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 11, 2021
@morgo
Copy link
Contributor

morgo commented Mar 15, 2021

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2021
xhebox
xhebox approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@xhebox: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2021
@xhebox
Copy link
Contributor

xhebox commented Mar 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 38282d6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit d4750fe into pingcap:release-4.0 Mar 16, 2021
@tiancaiamao tiancaiamao deleted the release-4.0-8304d661f3ba branch March 16, 2021 03:14
@glorv glorv mentioned this pull request Mar 17, 2021
Merged
@zhouqiang-cl zhouqiang-cl modified the milestones: v4.0.11, v4.0.12 Mar 26, 2021
@tiancaiamao tiancaiamao mentioned this pull request Mar 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@morgo morgo Awaiting requested review from morgo

Assignees

@tiancaiamao tiancaiamao

Labels
component/expression sig/sql-infra SIG: SQL Infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.12
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @morgo @ti-chi-bot @xhebox @tiancaiamao @zhouqiang-cl @ichn-hu